Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] module product_harmonized_system_per_country #281

Open
wants to merge 4 commits into
base: 16.0
Choose a base branch
from

Conversation

emiliesoutiras
Copy link

We need to be able to define different HS codes depending on the destination country, both for product categories and for the products themselves.
For example, the HS Code of a given product is different if you ship to the USA or to Canada, even though in both cases the origin is the same.

@emiliesoutiras
Copy link
Author

@metaminux, @akretion

@emiliesoutiras emiliesoutiras force-pushed the 16.0_add_product_harmonized_system_per_country branch 3 times, most recently from d4332f4 to 3049338 Compare September 12, 2024 09:04
@emiliesoutiras emiliesoutiras force-pushed the 16.0_add_product_harmonized_system_per_country branch 2 times, most recently from 5ce23da to d8447a6 Compare September 18, 2024 16:54
@emiliesoutiras emiliesoutiras force-pushed the 16.0_add_product_harmonized_system_per_country branch from d8447a6 to 7ff590f Compare September 18, 2024 17:01
@luc-demeyer
Copy link
Contributor

@emiliesoutiras

Can you provide evidence that this module is required ?

HS Code are defined on a global basis and the 6 digit HS Code is the same everywhere.
Countries can add specific digits. The 'local_code' field has been created to encode these differences.

In the current module, the 'company_id' field on the HS code allows to load different codes per company.
This is indeed something we could improve by making it country_id dependent in stead of company_id.

I think that such a change may do the job and removes the need for this module.

Copy link
Contributor

@luc-demeyer luc-demeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to accommodate this requirement into the base 'product_harmonised_system' module (cf. my comment in the conversation section of this PR).

@emiliesoutiras
Copy link
Author

emiliesoutiras commented Oct 2, 2024

@emiliesoutiras

Can you provide evidence that this module is required ?

HS Code are defined on a global basis and the 6 digit HS Code is the same everywhere. Countries can add specific digits. The 'local_code' field has been created to encode these differences.

In the current module, the 'company_id' field on the HS code allows to load different codes per company. This is indeed something we could improve by making it country_id dependent in stead of company_id.

I think that such a change may do the job and removes the need for this module.

@luc-demeyer

Our company currently has products manufactured in France and shipped to the US and Canada, and their HS code is different: for example, for the US, it's 4201.00.1000, and for Canada, it's 4201.00.6000.
We're talking about a single product from a single company, which must have a different HS code depending on the country of destination.

Firstly, the current design of the HS Code doesn't allow multiple HS Codes for the same product/category, so we're proposing a solution with relationships between HS Codes.
Secondly, we are proposing an optional country, so as to have a default HS Code (without company or country), and linked HS Codes that are by country, in order to dynamically find the right HS Code according to the destination country.

Conceptually, I'd ideally imagined a base code containing, for example, 420100 and a local_code per country containing 1000 for the US and 6000 for Canada, but I've adapted to the current design so as not to break everything.

You propose to make the HS Code dependent on the country_id, is there the same mechanism as the company_id dependency in Odoo? Or is it through SQL constraints on the model that you intend to do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants