-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] module product_harmonized_system_per_country #281
base: 16.0
Are you sure you want to change the base?
[ADD] module product_harmonized_system_per_country #281
Conversation
d4332f4
to
3049338
Compare
5ce23da
to
d8447a6
Compare
d8447a6
to
7ff590f
Compare
product_harmonized_system_per_country/models/product_product.py
Outdated
Show resolved
Hide resolved
Can you provide evidence that this module is required ? HS Code are defined on a global basis and the 6 digit HS Code is the same everywhere. In the current module, the 'company_id' field on the HS code allows to load different codes per company. I think that such a change may do the job and removes the need for this module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should try to accommodate this requirement into the base 'product_harmonised_system' module (cf. my comment in the conversation section of this PR).
Our company currently has products manufactured in France and shipped to the US and Canada, and their HS code is different: for example, for the US, it's 4201.00.1000, and for Canada, it's 4201.00.6000. Firstly, the current design of the HS Code doesn't allow multiple HS Codes for the same product/category, so we're proposing a solution with relationships between HS Codes. Conceptually, I'd ideally imagined a base code containing, for example, 420100 and a local_code per country containing 1000 for the US and 6000 for Canada, but I've adapted to the current design so as not to break everything. You propose to make the HS Code dependent on the country_id, is there the same mechanism as the company_id dependency in Odoo? Or is it through SQL constraints on the model that you intend to do this? |
We need to be able to define different HS codes depending on the destination country, both for product categories and for the products themselves.
For example, the HS Code of a given product is different if you ship to the USA or to Canada, even though in both cases the origin is the same.